Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add download link #323

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add download link #323

wants to merge 4 commits into from

Conversation

madhums
Copy link

@madhums madhums commented Sep 24, 2014

Adds a download link based on #312

@madhums madhums mentioned this pull request Sep 24, 2014
@kafeltz
Copy link

kafeltz commented Sep 25, 2014

Perfect... I have been waiting for this so long!

@LeOSW42
Copy link

LeOSW42 commented Sep 26, 2014

Works fine, already used on prod server

@vinitkumar
Copy link

We also use it on our production server. Please merge this @lokesh. It is pretty neat and much needed.

@gauravmanral gauravmanral mentioned this pull request Mar 3, 2015
@lokesh lokesh force-pushed the master branch 3 times, most recently from de83cee to c1c0f87 Compare June 16, 2015 04:14
@urtzai
Copy link

urtzai commented May 27, 2016

This feature needs to be merged... please...

@pierresh
Copy link

That would be very useful! 😃

@valix85
Copy link

valix85 commented Aug 23, 2016

Hi, I'm looking for a documentation for download button...where did you explain how to use it?

@sukima
Copy link

sukima commented Jun 28, 2017

What is the blocker for this review that started eight months ago? We are in desperate need for this feature.

@mfredriksen
Copy link

Besides making the necessary changes to both the lightbox.js and lightbox.css, as well as placing the icon in the appropriate image directory, what else is needed to make the "download" button/link work? I've done the aforementioned and see the icon appear, but when clicked, the link just opens a new browser window with the appropriate image. What's missing? Any other files that need to be amended or installed?

@direc85
Copy link

direc85 commented Jul 27, 2018

There seem to be conflicts that prevent merging. I could try to redo your patch against the current master... @madhums Is this fine with you?

@madhums
Copy link
Author

madhums commented Jul 30, 2018

@direc85 sure go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.